Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify kapitan/inputs/base.py #980

Open
gburiola opened this issue Mar 23, 2023 · 2 comments
Open

Simplify kapitan/inputs/base.py #980

gburiola opened this issue Mar 23, 2023 · 2 comments
Labels
enhancement enhancement to an existing feature Stale

Comments

@gburiola
Copy link
Contributor

Suggested by @MatteoVoges on #979 (comment)

Not sure why, but kapitan/inputs/base.py iterates on input_paths and not on the comp_obj directly.

With the changes introduced on #979, not all compile objects will have input_paths.

A workaround was introduced here to deal with these specific compile objects without input_paths

Aim of this issue is to investigate why we iterate on input_paths and not directly on comp_obj. If possible / feasible, change code to iterate on comp_obj to simplify the code.

@ramaro may have more context on this.

@ramaro
Copy link
Member

ramaro commented Mar 24, 2023

This might be a historic, original decision that just stayed like this while other things continued to change. I will give this some thought.

@MatteoVoges MatteoVoges added the enhancement enhancement to an existing feature label Apr 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement to an existing feature Stale
Projects
None yet
Development

No branches or pull requests

3 participants