Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify input type Helm #977

Open
gburiola opened this issue Mar 22, 2023 · 1 comment
Open

Simplify input type Helm #977

gburiola opened this issue Mar 22, 2023 · 1 comment
Labels
enhancement enhancement to an existing feature Stale

Comments

@gburiola
Copy link
Contributor

At the moment, in order to use input_type: helm we need to declare all of this:

parameters:

  kapitan:

    dependencies:
    - type: https
      source: https://<REPO_NAME>/<CHART_NAME>-<VERSION>.tgz
      unpack: True
      output_path: .charts

    compile:
      - output_path: my_dir
        input_type: helm
        input_paths:
          - .charts/<CHART_NAME>
        helm_values:
          key1: value1
        helm_params:
          name: my_release
          namespace: my_namespace

I propose we simplify the above, by removing the external dependency and using the helm cli directly to fetch the chart.

parameters:

  kapitan:

    compile:
      - output_path: my_dir
        input_type: helm
        helm_values:
          key1: value1
        helm_params:
          name: my_release
          namespace: my_namespace
          repo: <REPO_NAME>
          chart: <CHART_NAME>
          version: <VERSION>

We can do that by using the helm cli flags --repo <REPO_NAME> --version <VERSION> <CHART_NAME>
This would be done in this file here

Benefits

  1. Simplified inventory code
  2. No more locally fetched charts inside output_path: .charts
  3. In addition to the direct benefits listed above, it also allows us to use multiple different chart versions. At the moment this is not possible, because dependencies are extracted to <OUTPUT_PATH>/<CHART_NAME>. So if you fetch 2 different versions of the same chart they will overwrite each other.
gburiola added a commit that referenced this issue Mar 22, 2023
gburiola added a commit that referenced this issue Mar 22, 2023
gburiola added a commit that referenced this issue Mar 22, 2023
gburiola added a commit that referenced this issue Mar 27, 2023
@MatteoVoges MatteoVoges added the enhancement enhancement to an existing feature label Apr 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement to an existing feature Stale
Projects
None yet
Development

No branches or pull requests

2 participants