Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSRF issue #263

Closed
carsonchan12345 opened this issue May 11, 2024 · 1 comment
Closed

SSRF issue #263

carsonchan12345 opened this issue May 11, 2024 · 1 comment

Comments

@carsonchan12345
Copy link

carsonchan12345 commented May 11, 2024

SSRF issue is found on ?explorer/upload/serverDownload endpoint, app/controller/explorer/upload.class.php. It allows authenticated users to access and download files from any internal IP address and potentially cause lateral movement and data exfiltration. Should consider restricting the download to external IP address only.

@kalcaddle
Copy link
Owner

Thanks for the feedback. We have made restrictions in this area before, but there is indeed a need to obtain resources from the intranet. This restriction has been removed in all subsequent versions.
If you have relevant needs, you can make some adjustments.

https://github.com/kalcaddle/kodbox/blob/main/app/function/web.function.php#L628
add line such as:

if($info['host'] == 'localhost' || $info['host'] == '127.0.0.1' || strstr($info['host'],'192.168.')) return false;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants