Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #27

Open
JohnnyFun opened this issue Jan 15, 2020 · 0 comments
Open

Add tests #27

JohnnyFun opened this issue Jan 15, 2020 · 0 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@JohnnyFun
Copy link
Contributor

I may get to this at some point, but wanted to note it in case you're already working on it.

Some cases (not exhaustive):

  • basic scenario: <Loadable component={Component} />
  • with props: <Loadable component={Component} some="value" />
  • with page loader: <Loadable loader={() => getComponentDynamically()} />
  • with registered loader: <Loadable loader={register({ loader, resolve })} />
  • with default and loading slot: <Loadable ...><div slot="loading">loading...</div>...</Loadable>
  • others...but those ^ would be a good start

Could use cypress and cypress-svelte-unit-test. Or the test library that svelte itself uses. Or whatever the implementer's heart desires, so long as it asserts what needs to be asserted :)

@kaisermann kaisermann self-assigned this Feb 2, 2020
@kaisermann kaisermann added the help wanted Extra attention is needed label Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants