Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: lyrics lookup displays wrong information #398

Open
dmrazor opened this issue Mar 21, 2024 · 0 comments
Open

[Bug]: lyrics lookup displays wrong information #398

dmrazor opened this issue Mar 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dmrazor
Copy link

dmrazor commented Mar 21, 2024

What happened?

This is a longstanding issue. Looking up lyrics show wrong information. E.g. looking up "David Bowie" - "Scream Like A Baby" shows lyrics for "David Vendetta"- "Love To Love You Baby".

I think this is caused by an error in http://api.chartlyrics.com/apiv1.asmx/SearchLyricDirect which returns only the first lyric of a possible set of correct responses.

Using http://api.chartlyrics.com/apiv1.asmx/SearchLyric instead would return a list of all possible responses which (may) also contain the correct entry and its LyricID and LyricChecksum. This correct entry could then identified in Airsonic and the lyric retrieved with http://api.chartlyrics.com/apiv1.asmx/GetLyric using this LyricID and LyricChecksum.

I'm not a Java programmer, but this 2 step process doesn't seem to difficult to implement.

Steps to reproduce

Click on lyrics and often wrong ones are displayed

Version

11.1.2 (Stable)

Version Detail

No response

Operating System

Linux, Ubuntu 22.04.3LTS

Java Version

OpenJDK 11.0.22

Database

MariaDB 8.x

DB Detail

No response

Configuration paramter

Type=simple
Environment="JAVA_JAR=/var/airsonic/airsonic.war"
Environment="JAVA_OPTS=-Xmx700m"
Environment="AIRSONIC_HOME=/var/airsonic"
Environment="PORT=4040"
Environment="CONTEXT_PATH=/"
Environment="JAVA_ARGS="
#EnvironmentFile=-/etc/sysconfig/airsonic
ExecStart=/usr/bin/java
$JAVA_OPTS
-Dairsonic.home=${AIRSONIC_HOME}
-Dserver.servlet.contextPath=${CONTEXT_PATH}
-Dserver.port=${PORT}
-Dserver.forward-headers-strategy=native
-jar ${JAVA_JAR} $JAVA_ARGS

Proxy Server

No response

client detail

No response

language

None

Relevant log output

No response

@dmrazor dmrazor added the bug Something isn't working label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant