Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug notice in When running in Meteor Production mode #45

Open
sahanDissanayake opened this issue Dec 22, 2015 · 8 comments
Open

debug notice in When running in Meteor Production mode #45

sahanDissanayake opened this issue Dec 22, 2015 · 8 comments

Comments

@sahanDissanayake
Copy link

if you open https://kadira.io/ and see the console there is a console.debug
this should not appear on production mode

@arunoda
Copy link
Contributor

arunoda commented Dec 22, 2015

console.debug is something inside the browser. I don't think it's related to React in anyway.

@arunoda arunoda closed this as completed Dec 22, 2015
@sahanDissanayake
Copy link
Author

Well it is,

"production" !== n.env.NODE_ENV) {
                    var w = e("./ExecutionEnvironment");
                    if (w.canUseDOM && window.top === window.self) {
                        navigator.userAgent.indexOf("Chrome") > -1 && "undefined" == typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ && console.debug("Download the React DevTools for a better development experience: https://fb.me/react-devtools");
                        for (var O = [Array.isArray, Array.prototype.every, Array.prototype.forEach, Array.prototype.indexOf, Array.prototype.map, Date.now, Function.prototype.bind, Object.keys, String.prototype.split, String.prototype.trim, Object.create, Object.freeze], T = 0; T < O.length; T++)
                            if (!O[T]) {
                                console.error("One or more ES5 shim/shams expected by React are not available: https://fb.me/react-warning-polyfills");
                                break
                            }
                    }
                }

this is because react does not know the `NODE_ENV`` that's its on..

@sahanDissanayake
Copy link
Author

@arunoda
Copy link
Contributor

arunoda commented Dec 22, 2015

Okay.This is not related to console.debug. Something like react being added with dev mode. I assume this is something with the browserify setup.

I'll check.

@arunoda arunoda reopened this Dec 22, 2015
@sahanDissanayake
Copy link
Author

👍

@sahanDissanayake sahanDissanayake changed the title debug notice in React Production mode debug notice in When running in Meteor Production mode Dec 22, 2015
@sahanDissanayake
Copy link
Author

this is now fixed with the new react runtime update to 0.14.4

@sahanDissanayake
Copy link
Author

markshust added a commit to markshust/meteor-react-layout that referenced this issue Jan 6, 2016
@markshust
Copy link

This may be to the fact that I was running react-runtime 0.14.3, but react-layout was requiring 0.14.4. Pushing up this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants