Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict Typescript Options cause error output #499

Open
jtenner opened this issue Feb 21, 2020 · 2 comments · May be fixed by #500
Open

Strict Typescript Options cause error output #499

jtenner opened this issue Feb 21, 2020 · 2 comments · May be fixed by #500

Comments

@jtenner
Copy link

jtenner commented Feb 21, 2020

src/parser/grammar.ts(38,68): error TS6133: 'd' is declared but its value is never read.
src/parser/grammar.ts(41,70): error TS6133: 'd' is declared but its value is never read.

The workaround of course is to change my typescript config to:

{
  "noUnusedParameters": false
}

The offending rules are:

{
  ParserRules: [
    // ...
    {"name": "_", "symbols": ["_$ebnf$1"], "postprocess": function(d) {return null;}},
    // ... and
    {"name": "__$ebnf$1", "symbols": ["__$ebnf$1", "wschar"], "postprocess": (d) => d[0].concat([d[1]])},
   // ...
  ]
}

It would be nice to be able to avoid this problem though. Thoughts?

@jtenner
Copy link
Author

jtenner commented Feb 21, 2020

I can share my grammar and builtin usage if you want.

@jtenner
Copy link
Author

jtenner commented Feb 21, 2020

Ah. It looks like it's in the whitespace builtin!

@jtenner jtenner linked a pull request Feb 21, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant