Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail PRs that don't contain an update to the XML #16

Open
kabaros opened this issue Apr 24, 2020 · 0 comments
Open

Don't fail PRs that don't contain an update to the XML #16

kabaros opened this issue Apr 24, 2020 · 0 comments

Comments

@kabaros
Copy link
Owner

kabaros commented Apr 24, 2020

Currently, if a PR is opened against this repository and it doesn't contain a new plugin then the build will fail as it assumes any PR should be for a new release. That's not the case, as it might be just an update for the Readme or any supporting files in the future.

Maybe this is an acceptable behaviour, and we can just manually accept these Pull Requests - but just leaving this issue here to document the behaviour and agree on how we should proceed.
asmecher pushed a commit to asmecher/plugin-gallery that referenced this issue Dec 18, 2020
@NateWr
Merge pull request kabaros#16 from withanage/master
0623060 
ORCID Profile plugin updated for 3.1.2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kabaros