-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot use URL from openjdk code review server #52
Comments
See this comment: |
I tried this URL and got following errors in the browser console:
|
Many thanks for getting back to me. I've verified that indeed there are errors on the browser console, and raised the issue to our team in charge of the server configuration. I will update this issue once I know more. Thanks again. |
Hey @mcimadamore , it's a CORS issue. Because JMH visualizer doesn't have a server and just runs in the browser, it cannot fetch content from servers with a restrictive content policy. Workaround would be to use a proxy. So |
Nice trick/workaround - thanks! |
Closing this issue as it seems related to the configuration of the openjdk server |
I work on OpenJDK, and I'm trying to publish a JMH report using your great tool. I've uploaded my JMH json files here:
https://cr.openjdk.org/~mcimadamore/jdk/8331865/
Ideally, I'd like to pass the two URLs to the visualizer, so that I can then share the resulting page. But I'm not having luck with using such URLs. Using gist works (or uploading locally) - but I wonder if there's a reason as to why the URL function doesn't seem to work? (and, maybe also making sure it's not an issue on our end, e.g. our code review server).
The text was updated successfully, but these errors were encountered: