Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting infinite spam messages #70

Open
jxsl13 opened this issue Mar 30, 2020 · 3 comments
Open

getting infinite spam messages #70

jxsl13 opened this issue Mar 30, 2020 · 3 comments

Comments

@jxsl13
Copy link
Owner

jxsl13 commented Mar 30, 2020

when a player is moved to spec while caught, he gets spammed with
"you will join the game when XY dies." messages.
and seemingly after that player dies will forcfully join spec.

@jxsl13
Copy link
Owner Author

jxsl13 commented Apr 26, 2020

the moving is done by being afk for too long

@jxsl13
Copy link
Owner Author

jxsl13 commented May 13, 2020

on every tick after a player is being set to afk the current code tries to move that player to the spectators.
this is kind of bad, because if a player is caught, this causes tons of server messages saying that the player cannot be moved to the spectators.
A better approach would be to differentiate between manually wanting to join spec or being forced to join spec.

simply don't send the server message.

an approach to solve this would be to pass an optional enumeration parameter that by default is set to a player wanting to manually join the spectators and alternatively can be set to being forced to join due to being afk.

this extra parameter can be used to differentiate whether to send or not to send a server message to the player, that wants to join the spectators while being caught.

@jxsl13 jxsl13 added good first issue Good for newcomers and removed good first issue Good for newcomers labels May 13, 2020
@jxsl13
Copy link
Owner Author

jxsl13 commented May 13, 2020

(bad first issue, as problem hard to reproduce)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant