Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typings #69

Open
elecompte60 opened this issue Feb 10, 2020 · 7 comments
Open

Add Typings #69

elecompte60 opened this issue Feb 10, 2020 · 7 comments

Comments

@elecompte60
Copy link

Would be very useful if this library included Type definitions (@types/njwt apparently has not been created by a type definition contributor yet)

@swiftone
Copy link
Contributor

@elecompte60 - Thanks for the feedback! We are adding TypeScript definitions to our repositories but we have a number of repos to update and it may take a while for this one to hit the top of the priority list.

@swiftone
Copy link
Contributor

Internal ref: OKTA-279231

@iam-yan
Copy link

iam-yan commented Aug 8, 2020

@swiftone any update?

@swiftone
Copy link
Contributor

Okta (who now manages this library) has introduced typescript definitions to its okta-auth-js library. Next high level target is adding definitions to the front end SDKs that consume okta-auth-js, so I expect njwt will fall somewhere in there, but I'll poke the involved devs to see where it falls.

@masonlouchart
Copy link

Is there any updates?

@danbulant
Copy link

jwt now has typings, but for example the typings for verify are wrong (the callback doesn't get kid and callback but error: Error | undefined and data: Jwt | undefined).

@oleksandrpravosudko-okta
Copy link
Collaborator

@danbulant would you mind elaborating on which signature appears to be wrong? The parameters you mention (kid and callback) are passed to key resolver callback - there seem to be no verify signature in JS code expecting them.

Please also feel free to submit a PR with a suggested change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants