Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: throw an error if you call create with string as signing key instead of a Buffer #53

Open
pingvinen opened this issue Jul 6, 2018 · 0 comments

Comments

@pingvinen
Copy link

Today I spent more time than I care to admit chasing down a bug in my authentication mechanism. I kept getting correctly looking JWTs, but they would not be accepted by my other services (that are not running on node).

In the end, it turned out to be a simple mistake of me providing create with string as signing key instead of a Buffer.

Is there a specific reason that create does not raise an error saying that I am doing something dumb?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant