Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

views should not mutate options passed into them #24

Open
go-oleg opened this issue Jan 18, 2016 · 0 comments
Open

views should not mutate options passed into them #24

go-oleg opened this issue Jan 18, 2016 · 0 comments
Labels

Comments

@go-oleg
Copy link
Contributor

go-oleg commented Jan 18, 2016

As timechart applies defaults to options passed into it and then transforms them to its internal representation, it should not mutate the original objects.

This was discovered while investigating juttle/outrigger#83.

This ticket is about ensuring that timechart and the rest of the views don't mutate any objects passed into them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant