Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work well when aspect ratio is different from 16:9 #92

Open
elibarzilay opened this issue Jul 23, 2023 · 0 comments · May be fixed by #96
Open

Doesn't work well when aspect ratio is different from 16:9 #92

elibarzilay opened this issue Jul 23, 2023 · 0 comments · May be fixed by #96

Comments

@elibarzilay
Copy link
Contributor

I have a page with a few videos that have a weird non-16/9 aspect ratio. The result renders that inside of a 16/9 iframe which makes it look bad. I just blindly grepped the code for 16 / 9 and changed it which looks like it makes it work as intended.
elibarzilay added a commit to elibarzilay/lite-youtube that referenced this issue Jul 23, 2023
@elibarzilay
Add an aspectratio attribute
8e56879 
Makes it possible to handle non-16/9 videos, and fixes justinribeiro#92.
@elibarzilay elibarzilay mentioned this issue Jul 23, 2023
Closed
@elibarzilay elibarzilay changed the title Fixed aspect ratio doesn't work when ... it's different Doesn't work well when aspect ratio is different from 16:9 Jul 23, 2023
elibarzilay added a commit to elibarzilay/lite-youtube that referenced this issue Jul 28, 2023
@elibarzilay
Add an aspectratio attribute
2271641 
Makes it possible to handle non-16/9 videos, and fixes justinribeiro#92.
@elibarzilay elibarzilay linked a pull request Jul 28, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@elibarzilay