Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust warmConnections if using nocookie attribute, add profile image domain #101

Open
mrwweb opened this issue Dec 6, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mrwweb
Copy link
Contributor

mrwweb commented Dec 6, 2023

From what I can see, it seems that the warmConnections() function will preconnect to all of these domains regardless of the nocookie attribute:

Looking at a request to youtube-nocookie.com, I think the only connections that should preconnect should be:

Looking at an embed request, I'm also seeing that YouTube profile icons are loaded from https://yt3.ggpht.com, so that would be a good one to add to both preconnect lists.

I'm willing to take a stab at a PR if you agree and think this makes sense.

@XhmikosR
Copy link

@mrwweb I totally agree with your OP. Could you please make a PR?

@justinribeiro: @mrwweb is right in his observations :)

@justinribeiro
Copy link
Owner

I concur; I'll either take a PR for this or I'll put it on the list this week.

@justinribeiro justinribeiro self-assigned this Apr 2, 2024
@justinribeiro justinribeiro added the bug Something isn't working label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants