Improve paging hint #370
Open
Improve paging hint #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* which-key.el (which-key--next-page-hint): avoid suggesting C-h when it is known not to work; suggest alternatives that are likely to work.
|
Thanks. Sorry for not asking earlier, but have you assigned your copyright to the FSF (see here)? |
|
It’s in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve the paging hint displayed when all key bindings do not fit on the screen.
C-hwhen it will certainly not work,?and<f1>),'which-key-C-h-dispatch(when present).This should improve the experience for newcomers a bit.
Tested under clean Emacs 29.3 and Doom v3.0.0-pre from yesterday.
When testing today I've noticed that
C-h C-hnow works under Doom and displays the paging prompt, while it certainly did not when I submitted #368, and it still does not in "clean" Emacs. However in the original implementation we would not display any paging hint at all, so I don't think we are making anything worse.Closes #368