Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect signature for custom-esbuild index html transform function #1756

Closed
exequiel09 opened this issue Apr 24, 2024 · 1 comment · Fixed by #1757
Closed

Incorrect signature for custom-esbuild index html transform function #1756

exequiel09 opened this issue Apr 24, 2024 · 1 comment · Fixed by #1757

Comments

@exequiel09
Copy link
Contributor

exequiel09 commented Apr 24, 2024

Describe the Bug

According to Angular CLI codebase, the type signature of the transform function only includes the HTML and not the target.

In the docs, it includes both.

Expected Behavior

Target options should be passed as is or align the docs with Angular CLI.

Environment


Libs
- @angular/core version: 17.3.5
- @angular-devkit/build-angular version: 17.3.5
- @angular-builders/custom-esbuild version: 17.1.2

For Tooling issues:
- Node version: 20.10.0
- Platform:  Windows
@exequiel09
Copy link
Contributor Author

If someone is using Nx, you can use the following environment variables to retrieve it during the transformer execution:

  1. NX_TASK_TARGET_PROJECT
  2. NX_TASK_TARGET_TARGET
  3. NX_TASK_TARGET_CONFIGURATION

Reference: https://nx.dev/reference/environment-variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant