You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found this while looking into how DockerSpawner calls docker as inspiration for a similar spawner for Apptainer. It's a significant enough potential issue that I wanted to raise it.
Review the development activity around docker-py. There are some recent contributions, but the number of issues and PRs are significant.
Decide on whether on not to find alternative to docker-py. Python-on-Whales may be better than maintaining a separate wrapper to the Docker CLI or API. It may or may not be a drop-in replacement.
Determine the amount of code and documentation changes, along with any new dependency issues.
Plan on a target release, code, test, etc.
The text was updated successfully, but these errors were encountered:
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋
So I don't think switching to a CLI wrapper (either our own or python-on-whales) is too difficult. It's a question of is it worth it and if so, how soon is it needed? It's obviously best not to use an unmaintained package, but there's only one CVE for docker-py from 2014.
I don't feel moving away from docker-py is urgent, unless something changes, like:
A critical CVE in docker-py that can't be mitigated by a change to DockerSpawner
Incompatibility with a newer version of Docker, Python, or a docker-py dependency
However, it does seem like an issue to have on the radar so that it's not a surprise if docker-py can't be used, or if there's an opportunity to make a change with other benefits. And I am too unfamiliar with Docker to say whether a CLI wrapper library would be the better solution, I was just glad to have something to list under alternative options.
I found this while looking into how DockerSpawner calls docker as inspiration for a similar spawner for Apptainer. It's a significant enough potential issue that I wanted to raise it.
Proposed change
There is a current PR in the docker-py repo to list the package as unmaintained.
Alternative options
One of the commenters on the PR has an alternative package that calls the Docker CLI. This may be replacement for docker-py.
Who would use this feature?
This would impact all DockerSpawner users.
(Optional): Suggest a solution
The text was updated successfully, but these errors were encountered: