Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinderHub.build_node_selector vs KubernetesBuildExecutor.node_selector #1723

Open
rgaiacs opened this issue Jun 22, 2023 · 0 comments
Open

BinderHub.build_node_selector vs KubernetesBuildExecutor.node_selector #1723

rgaiacs opened this issue Jun 22, 2023 · 0 comments

Comments

@rgaiacs
Copy link
Contributor

rgaiacs commented Jun 22, 2023 •
edited

I see

[BinderHub] WARNING | BinderHub.build_node_selector is deprecated, use KubernetesBuildExecutor.node_selector

in the pod execution log but

binderhub/helm-chart/binderhub/templates/container-builder/daemonset.yaml

Line 37 in 6f03245

nodeSelector: {{ .Values.config.BinderHub.build_node_selector | toJson }}
ignores KubernetesBuildExecutor.node_selector.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rgaiacs