New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce DisplayNameGenerator to support CamelCase, underscores, and numbers #793
Comments
Added label "blocked" for now, until JUnit team decided |
We are Pioneers! We bravely go where no man has gone before! I say let's integrate this into Pioneer and if JUnit decides to officially support this we can still remove/deprecate it. |
Convinced :) Do you start the countdown? 🚀 |
Well they have decicded on #1595 already in 2020 to not implement it, cause of edge cases. I thin that opens the door for pioneering it even more |
Great, lets go 😊 |
So, can I PR ? |
Yes, feel free to go ahead with a PR. If you don't have the time for it, we will eventually get around to it. |
@Bukama , please assign me this issue. |
Hey @FanJups On our yesterdays team meeting we talked about this issue and as you have not responded to @Michael1993 comment in any kind of form (comment, question or PR) we assumed that you abandoned the topic and @Michael1993 volunteered to give it a shot. I will assign the issue to you now, but assuming you will present any progress on it (e.g. a draft PR) in the near future. |
Thanks @Bukama , it will be ready for review no later than May 19. |
…junit-pioneer#793 / #)** This extension handles method names with CamelCase, underscore and numbers. The aim is to simplify unit test display names. Instead of using this method annotation org.junit.jupiter.api.DisplayName on every method, we can just use this class annotation org.junit.jupiter.api.DisplayNameGeneration and use that method annotation if needed. This generator follows 3 rules: - Each uppercase letter is turned into its lowercase value prepended by space. - Each underscore is turned into space. Words bounded by underscores or just starting with underscore are not transformed. Usually these words represent classes, variables... - Each number is prepended by space. Closes: junit-pioneer#793 PR: #
…unit-pioneer#793 / junit-pioneer#819) This extension handles method names with CamelCase, underscore and numbers. The aim is to simplify unit test display names. Instead of using this method annotation org.junit.jupiter.api.DisplayName on every method, we can just use this class annotation org.junit.jupiter.api.DisplayNameGeneration and use that method annotation if needed. This generator follows 3 rules: - Each uppercase letter is turned into its lowercase value prepended by space. - Each underscore is turned into space. Words bounded by underscores or just starting with underscore are not transformed. Usually these words represent classes, variables... - Each number is prepended by space. Closes: junit-pioneer#793 PR: junit-pioneer#819
I created a new PR. Before moving forward with documentation, please I want your feedback on what is already done. I faced an issue regarding one of my test classes. |
See the JUnit 5 issues: #3569 and #1595.
If JUnit 5 decides not to host/support this, I think we should - let's wait for their team decision. 😄
The text was updated successfully, but these errors were encountered: