Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest FZF fails due to interaction with Oh-my-zsh #3616

Closed
5 of 10 tasks
purplefishies opened this issue Feb 6, 2024 · 1 comment
Closed
5 of 10 tasks

Latest FZF fails due to interaction with Oh-my-zsh #3616

purplefishies opened this issue Feb 6, 2024 · 1 comment

Comments

@purplefishies
Copy link

  • I have read through the manual page (man fzf)
  • I have the latest version of fzf
  • I have searched through the existing issues

Info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Etc.
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

  1. Cygwin system with zsh installed but not fzf
  2. Install fzf from https://github.com/junegunn/fzf ( to ~/.fzf per the instructions )
  3. Run standard fzf install ( installs both Bash and Zsh bindings to ~/.bashrc and ~/.zshrc )
  4. source ~/.zshrc
  5. Type ctrl-r to start searching # triggers FZF
    Arrow keys select works
  6. Install oh-my-zsh
  7. source $ZSH/oh-my-zsh.sh
  8. Type ctrl-r to start searching
  9. Up and Down arrow keys don't work however
    ControlP and ControlN allow you to move around .

Notes:

  1. Bash arrow keys work perfectly for history search
  2. I can run
    find . -type f -maxdepth 1 | fzf # and arrow keys work
  3. Just the history search part of zsh seem to ignore the arrow keys.
@purplefishies purplefishies changed the title Latest FZF fails Latest FZF fails with interaction with Oh-my-zsh Feb 6, 2024
@purplefishies purplefishies changed the title Latest FZF fails with interaction with Oh-my-zsh Latest FZF fails due to interaction with Oh-my-zsh Feb 6, 2024
@junegunn
Copy link
Owner

junegunn commented Feb 7, 2024

Is it an issue of fzf or oh-my-zsh? I don't think we've changed any code that would cause the described problem recently.

EDIT: Oh, we actually upgraded tcell dependency in 0.46.1. Can you check if the problem is reproducible with 0.46.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants