Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mutation observer for chat #1

Open
nightwing opened this issue Jun 29, 2016 · 1 comment
Open

remove mutation observer for chat #1

nightwing opened this issue Jun 29, 2016 · 1 comment

Comments

@nightwing
Copy link
Collaborator

I'll change chat plugin to add "you" or "own-message" class by default.

The other thing is anim-start class added in https://github.com/jumbojett/c9.ide.theme.jett/blob/master/plugin.js#L185
Why is it required? looks like using delay in animation would accomplish the same.

@jumbojett
Copy link
Owner

jumbojett commented Jul 20, 2016

@nightwing Apologies for the delay. I just noticed this issue.

I'll change chat plugin to add "you" or "own-message" class by default.
The mutation observer was added due to the lack of CSS classes on those elements

If they were present by default then "yes" the mutation observer could be removed! Can you reference a commit to the collab plugin so I can verify this?

Why is it required? looks like using delay in animation would accomplish the same.

You're correct again. This was coded on the fly. CSS3 delay could accomplish the same.

Feel free to submit a PR. :)

Repository owner deleted a comment from pavana21 Feb 23, 2024
Repository owner deleted a comment from pavana21 Feb 23, 2024
Repository owner deleted a comment from pavana21 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@nightwing @jumbojett and others