Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move import sorting to JuliaFormatter.jl? #1262

Open
MilesCranmer opened this issue Jan 6, 2024 · 2 comments
Open

Move import sorting to JuliaFormatter.jl? #1262

MilesCranmer opened this issue Jan 6, 2024 · 2 comments

Comments

@MilesCranmer
Copy link

MilesCranmer commented Jan 6, 2024

@fredrikekre @pfitzseb I was wondering if the code action implemented in #1076 could instead be moved to JuliaFormatter.jl, and then called via LanguageServer.jl? Having it implemented in LanguageServer directly makes it a bit tricky to automate things – like using that feature it in a pre-commit hook or in CI testing.

@fredrikekre
Copy link
Member

I thought that was already part of the formatter (too).

@MilesCranmer
Copy link
Author

I don't think so, sadly. It's in a few of the style guides but you still need to perform the sorting manually. As far as I can tell you have written the only implementation of an import sorter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants