Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some API/documentation issues #40

Open
yurishkuro opened this issue May 7, 2019 · 1 comment
Open

Some API/documentation issues #40

yurishkuro opened this issue May 7, 2019 · 1 comment

Comments

@yurishkuro
Copy link

initTracer

$tracer = $config->initTrace('example', '0.0.0.0:6831');
  • should be initTracer
  • The parameters look positional, is only UDP sender currently supported?

Close Trace(r)?

$config->setDisabled(true);

I am not sure what this does. Method does not have English comment.

Flush trace

$config->flush();

This method looks like it forces flushing of all spans from memory buffers - should it not be a method on the Tracer object then? Config is just a factory for the Tracer.

@jukylin
Copy link
Owner

jukylin commented May 7, 2019

  • The parameters look positional, is only UDP sender currently supported?

Yes, now only supported UDP.

  • I am not sure what this does. Method does not have English comment.

if set that true, will get NoopTracer object.

  • This method looks like it forces flushing of all spans from memory buffers - should it not be a method on the Tracer object then? Config is just a factory for the Tracer

Yes, I want to flush all spans in the end. but you can do this on the Tracer object too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants