Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: remove_application support timeout and status output #855

Open
beliaev-maksim opened this issue May 16, 2023 · 6 comments
Open

[Feature]: remove_application support timeout and status output #855

beliaev-maksim opened this issue May 16, 2023 · 6 comments
Labels
wishlisted requested feature

Comments

@beliaev-maksim
Copy link

Description

We have a test where we want to remove the app and deploy another one

However, juju for unrelated to this lib reason cannot effectively remove the app and apps stays in terminated state (I assume)
and our CI test hangs for 6h until GitHub kills the runner.

would be great if remove_application would support timeout argument (similar to wait_for_idle)
and if it will print into STDOUT status of the app/unit that was requested to terminate (similar to wait_for_idle but only for this app)

Urgency

It would save from a weird workaround

Code I'd Like to Run

await ops_test.model.remove_application(APP_NAME, block_until_done=True, timeout=600)
@beliaev-maksim beliaev-maksim added the wishlisted requested feature label May 16, 2023
@github-actions
Copy link

This issue is marked as incomplete because it has been open 30 days with no activity. Please remove incomplete label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the incomplete old issue, check if it's still valid label Jul 22, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2023
@beliaev-maksim
Copy link
Author

@cderici not sure that feature requests should be autoclosed in 30 days

@cderici
Copy link
Member

cderici commented Jul 28, 2023

@cderici not sure that feature requests should be autoclosed in 30 days

good point. I'll add the wishlisted label to the exempt labels for the stale bot 👍

@beliaev-maksim
Copy link
Author

@cderici reopen this one or we decide as no go for this feature?

@cderici
Copy link
Member

cderici commented Jul 28, 2023

@beliaev-maksim yeah feel free to reopen any issues/PRs you want 👍

@cderici cderici reopened this Jul 28, 2023
@cderici cderici mentioned this issue Jul 28, 2023
Merged
@cderici cderici removed the incomplete old issue, check if it's still valid label Jul 28, 2023
jujubot added a commit that referenced this issue Jul 28, 2023
@jujubot
Merge pull request #926 from cderici/feature-requests-exempt-from-sta…
85a32a9 
…le-bot

#926

#### Description

Currently the stale bot marks all the issues that haven't been updated for 30 days with `incomplete` and closes the issue 5 days after that if there's no update.

This change prevents the stale bot from bothering the feature requests (i.e. issues marked with `wishlisted` label), which can (and should imo) stay as long as needed.

Discussed a bit in #855, suggested #855 (comment)
@yanksyoon yanksyoon mentioned this issue Jan 27, 2024
Merged
jujubot added a commit that referenced this issue Feb 1, 2024
@jujubot
Merge pull request #1018 from yanksyoon/feat/remove_application_timeout
16149db 
#1018

#### Description

*<Please add why this change is needed and what it does.>*
Adds timeout parameter to `model.remove_application()`
Addresses #855 

*<Fixes: >*


#### QA Steps

*<Commands / tests / steps to run to verify that the change works:>*
```
tox -e integration -- -k test_app_remove_timeout
```

All CI tests need to pass.

*<Please note that most likely an additional test will be required by the reviewers for any change that's not a one liner to land.>*

#### Notes & Discussion

*<Additional notes for the reviewers if needed. Please delete section if not applicable.>*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wishlisted requested feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cderici @beliaev-maksim