Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to deploy charm with branch in channel #832

Open
carlcsaposs-canonical opened this issue Apr 18, 2023 · 7 comments
Open

[Bug]: Unable to deploy charm with branch in channel #832

carlcsaposs-canonical opened this issue Apr 18, 2023 · 7 comments
Labels
wishlisted requested feature

Comments

@carlcsaposs-canonical
Copy link

Description

Unable to deploy charm with branch (e.g. 8.0/edge/pr-3)

def parse(s):
"""parse a channel from a given string.
Parse does not take into account branches.

Urgency

Annoying bug in our test suite

Python-libjuju version

2.9.38.1

Juju version

2.9.29

Reproduce / Test

from pytest_operator.plugin import OpsTest

MYSQL_APP_NAME = "mysql-k8s"

async def test_deploy(ops_test: OpsTest):
    await ops_test.model.deploy(
        MYSQL_APP_NAME,
        channel="8.0/edge/mysqlrouter-user",
        application_name=MYSQL_APP_NAME,
        num_units=3,
        trust=True,
    )
@juanmanuel-tirado
Copy link
Contributor

I will add this to the wishlist.

@juanmanuel-tirado juanmanuel-tirado added wishlisted requested feature and removed bug labels Apr 19, 2023
@carlcsaposs-canonical
Copy link
Author

I will add this to the wishlist.

thank you!

@github-actions
Copy link

This issue is marked as incomplete because it has been open 30 days with no activity. Please remove incomplete label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the incomplete old issue, check if it's still valid label Jul 22, 2023
@carlcsaposs-canonical
Copy link
Author

Still an issue

@cderici cderici removed the incomplete old issue, check if it's still valid label Jul 24, 2023
@ca-scribner
Copy link

Kubeflow team is hit by this too. For cases where two charms need to change at once (like if we change a relation), we'd like to use branches in tests so we do not have to always build all charms locally.

@cderici
Copy link
Member

cderici commented Feb 8, 2024

Looks like this has fallen through the cracks, thanks for the ping, we'll get on it (in the next pulse). I might ask you later @ca-scribner about some branches we can test this on.

@ca-scribner
Copy link

ty @cderici! Happy to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wishlisted requested feature
Projects
None yet
Development

No branches or pull requests

4 participants