Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -S option when calling add-apt-repository for a line starting with deb #771

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add -S option when calling add-apt-repository for a line starting with deb #771

wants to merge 2 commits into from

Conversation

verterok
Copy link

@verterok verterok commented Apr 19, 2023 •
edited

This is only for jammy or newer, and it just bypass any custom ppa logic in add-apt-repository by passing -S if the source line starts with deb.
fixes #770

@verterok verterok changed the title Add -S option when calling add-apt-repository for a line starting with deb (fix #770) Add -S option when calling add-apt-repository for a line starting with deb (fix [#770](https://github.com/juju/charm-helpers/issues/770)) Apr 19, 2023
@verterok verterok changed the title Add -S option when calling add-apt-repository for a line starting with deb (fix [#770](https://github.com/juju/charm-helpers/issues/770)) Add -S option when calling add-apt-repository for a line starting with deb Apr 19, 2023
@verterok
Copy link
Author

Take this as an idea on a possible fix, I'm far from an expert on charmhelper internals and this also requires some tests.
We are using this in our code to work around the issue.

ajkavanagh
ajkavanagh requested changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the code suggestion. I don't then the suggested patch actually works, and it definitely needs unit tests to verify that it does what is expected, please.

charmhelpers/fetch/ubuntu.py Outdated Show resolved Hide resolved
@ajkavanagh ajkavanagh added the Incomplete For an issue, needs more information. For a PR, needs further work. label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkavanagh ajkavanagh ajkavanagh requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Incomplete For an issue, needs more information. For a PR, needs further work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetch.add_source fails for private ppa on jammy
2 participants
@verterok @ajkavanagh