Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected escape of fetch.ubuntu._run_with_retries without successfully finishing the command #743

Open
addyess opened this issue Oct 26, 2022 · 0 comments

Comments

@addyess
Copy link
Contributor

addyess commented Oct 26, 2022

fetch.ubuntu._run_with_retries seems to escape without raising an exception in the event that the subprocess.check_call yields an exit code not in the list of retry_exitcode

this gives this method a false success when in reality it should fail immediately (no retrying)

i think the library method should raise when the exit value of subprocess.check_call is an error not on the rety list

TLDR:
if its exit value is 0 -- 🎉
if the exit value is in the retry_results -- retry max_retries like expected
if the exit value is not in the retry_results -- 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant