Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to sign certificates for None if ip not resolved #733

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not try to sign certificates for None if ip not resolved #733

wants to merge 2 commits into from

Conversation

tbaumann
Copy link

Fixes #732

Tilman Baumann added 2 commits September 14, 2022 18:13
Do not try to sign certificates for None if ip not resolved
86bb28d 
Fixes juju#732
Fallback to fqdn vs IP and don't fail on ipv6 addresses
51ff29e 
Filling in local hostname if a local IP can't be resolved seems like a
better fallback.
Revisiting 4231a52

Also ignoring errors when trying to look up a IPv6 address in a IPv4
subnet which will not work.

Referring to  juju#732
@ajkavanagh
Copy link
Collaborator

It looks like tests are failing: tox -e py310 (that uses nose2):

----------------------------------------------------------------------
Ran 1936 tests in 7.439s

FAILED (errors=5)
Name

@ajkavanagh ajkavanagh added the Incomplete For an issue, needs more information. For a PR, needs further work. label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Incomplete For an issue, needs more information. For a PR, needs further work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contrib.opensack.cert_utils.get_certificate_request like() can greate None indexted list
2 participants
@tbaumann @ajkavanagh