Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android target android api too high #28

Open
amoghbl1 opened this issue Mar 20, 2014 · 4 comments
Open

Android target android api too high #28

amoghbl1 opened this issue Mar 20, 2014 · 4 comments

Comments

@amoghbl1
Copy link
Contributor

The current android target api has been set to 17 but it can be reduced down to 11! This would allow more users to use the app, we should also try to change the current code to use the support libraries, this way, we would be able to provide the app to many more users...

@phinfinity
Copy link
Collaborator

The current minsdk is 14 (ICS 4.0).
There are two minsdk bumps as far as I can remember
11->14 MyNestedViewPager.java:23 , I'm actually not sure if this really needs this and it might actually work from 11 itself.
The more relevant bump:
9->11 This was needed for the SearchView widget.
I quite simply could not manage to get the SearchView widget working on Gingerbread 2.3 using the support libraries. I don't see much point in trying to compromise to bring it down to 11, since 11 is just honeycomb which is practically non-existent. I would be willing to go down till 9 though, since gingerbread is a decent population.
If someone can get the SearchView widget working on 2.3 using the support library I would be more than happy to port this down to API version 9.
can you provide a simple sample app which just has the SearchView widget working on 2.3? I couldn't get a way to do this and gave up after a considerable amount of searching.

@amoghbl1
Copy link
Contributor Author

ViewPager is actually a part of the support v4 libraries! So it supports api 4+ ... SearchView widget is a part of the v7 libraries so it should work fine after the right imports are made, I'll try it out and get back to you, but api 11 should work fine for now...

@phinfinity
Copy link
Collaborator

I finally got an answer on https://stackoverflow.com/questions/21265690/searchview-in-actionbar-using-support-v7-appcompat , which I realise now was my fault for not properly following the app-compat guide! So there should be no issues in getting SearchView on API 9 (or maybe even 7 as the appcompat7's name suggests)

@amoghbl1
Copy link
Contributor Author

Awesome, a lot more users can use the app now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants