Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out how to support FileAttachment #41

Open
timelyportfolio opened this issue May 4, 2021 · 5 comments
Open

figure out how to support FileAttachment #41

timelyportfolio opened this issue May 4, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@timelyportfolio
Copy link
Collaborator

FileAttachment does not seem to work. Explore possibility of adding support for it.

@timelyportfolio timelyportfolio added the enhancement New feature or request label May 4, 2021
@juba
Copy link
Owner

juba commented May 5, 2021

No, I think your error is linked to the fact that Object.fromEntries is not supported by the RStudio underlying web engine (a chromium version which is a bit outdated). It should work if you open it in a more recent browser, or if you run it in VSCode for example.

The latest RStudio version embeds chromium v69, and Object.fromEntries is supported starting with chromium v73.

@juba
Copy link
Owner

juba commented May 5, 2021

Yes, but I think the user agent string here (Chrome/69.0.3496.128) means that the underlying chromium version is the same as in stable. Did you try to open the result in a browser to see if it works ?

@hrbrmstr
Copy link

hrbrmstr commented May 5, 2021

ah! (i'm daft) yep. i see what you mean now. it's fine in Edge/Chrome.

and i think i got messed up b/c i hadn't tried it with and without a notebook that used FileAttachment.

apologies for messing up the issue. I'll delete the previous thread entries.

@timelyportfolio
Copy link
Collaborator Author

@hrbrmstr @juba maybe we should open another issue to build some plot examples and discuss some of these complicating issues. Bob, not unexpected, we are thinking the same thing :)

@juba
Copy link
Owner

juba commented May 24, 2021

@timelyportfolio I wanted to take a look at this issue but I'm not sure what you mean precisely about the lack of support of FileAttachment ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants