Refactor deprecated dark-mode functionality #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove deprecated GitHub README.md #gh-dark-mode-only and #gh-light-mode-only implement now GitHub README.md supported prefers-color-scheme media feature in CSS indent code for readability
to reflect refactoring of dark-mode support for statistical visualizations
replace accidentally added changes with correct and tested changes
Thank you! |
Drarig29
added a commit
to Drarig29/Drarig29
that referenced
this pull request
Jun 26, 2023
Drarig29
added a commit
to Drarig29/Drarig29
that referenced
this pull request
Jun 26, 2023
|
Hi @jstrieb what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95
Replaced deprecated
#gh-dark-mode-onlyand#gh-light-mode-onlyfunctionality with@media (prefers-color-scheme: dark)intemplates/languages.svgandtemplates/overview.svg.Edited
README.mdto reflect changes in.svgfiles: unappended#gh..from images and removed the now redundant second displaying of the generated images.Also indented the
.svgfiles for readability.Example
The following two dark/light mode examples display the changes in this PR, but the statistics being visualized are mine:
Dark mode - Firefox
Light mode - Chrome