Fix inaccurate notifications issue #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Broke the tests somehow... |
The `pomo notify` command uses the the `pomo_msg` bash function which sleeps until the current cycle portion should end. Upon waking up, it checks `pomo_stat` for the current pomodoro state. In order to get an accurate state, `pomo_update` needs to be called first because the pomodoro timer may have been restarted while `pomo_msg` was sleeping.
|
Looking at the tests and realizing that adding this So I removed these tests in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pomo notifycommand uses the thepomo_msgbash function which sleeps until the current cycle portion should end. Upon waking up, it checkspomo_statfor the current pomodoro state. In order to get an accurate state,pomo_updateneeds to be called first because the pomodoro timer may have been restarted whilepomo_msgwas sleeping.Fixes #14