Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Regex Description (section 7.3.8) should follow format of other string validation types #1474

Open
dlemire60 opened this issue Dec 20, 2023 · 0 comments

Comments

@dlemire60
Copy link

dlemire60 commented Dec 20, 2023

re: draft-bhutton-json-schema-validation-01: The defined format descriptions in 7.3.1 - 7.3.7 use consistent language: "A string instance is valid against this attribute if ..."

The language in 7.3.8 is different, simply saying "A regular expression, which SHOULD be valid according to the ECMA 262 regular expression dialect."

I found this language unclear in describing that the string instance being validated should be a regex, rather than conforming to a regex. I recommend updating the wording in 7.3.8 to align with the preceding sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant