Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't be used in ViewPager2 because swipe doesn't work #83

Open
anthonybattel opened this issue Dec 12, 2019 · 14 comments
Open

Can't be used in ViewPager2 because swipe doesn't work #83

anthonybattel opened this issue Dec 12, 2019 · 14 comments

Comments

@anthonybattel
Copy link

anthonybattel commented Dec 12, 2019

Unfortunately it doesn't work with ViewPager2. I can zoom in the photo but the ViewPager's swipe is broken so I can't see my next photos in the slideshow.
This library seems to work with but there is no customization like yours

@anthonybattel anthonybattel changed the title Can't be used in ViewPager because swipe doesn't work Can't be used in ViewPager2 because swipe doesn't work Dec 12, 2019
@DanGdl
Copy link

DanGdl commented Jan 4, 2020

Try to override onTouch behavior: swipe in normal scale - don't handle it (so view pager can get this event)

@jsibbold
Copy link
Owner

jsibbold commented Jan 6, 2020

working on getting a fix for this into a snapshot soon

@jsibbold
Copy link
Owner

snapshot is up for this, 1.3.1-SNAPSHOT

@anthonybattel
Copy link
Author

Thanks a lot

@jsibbold
Copy link
Owner

jsibbold commented Feb 7, 2020

No problem, if you run into issues with it, let me know, otherwise I'll look to get this out of snapshot and into official release in a couple weeks.

@usmanrana07
Copy link

@anthonybattel can you please share the results if you have used this update?

@jsibbold
Copy link
Owner

1.3.1 is in jcenter now

@anthonybattel
Copy link
Author

@usmanrana07 I finally used this library because 1.3.1 zoomage version was not released . You can handle some events this way in Kotlin :

photo_view.apply {
setOnScaleChangeListener { _, _, _ ->
doSomething()
}
setOnPhotoTapListener { _, _, _ ->
doSomething()
}
setOnOutsidePhotoTapListener {
doSomething()
}
}

I have not tested 1.3.1 zoomage

@usmanrana07
Copy link

@anthonybattel 1.3.1 version is released now. so, I'm giving it a try as I was using PhotoView before. That too has pretty much rating but in ViewPager2 its scroll was not upto the mark. So, I'm looking for some better library. Anyways thanks for your response.

@jsibbold
Copy link
Owner

Are you still seeing issues scrolling or swiping with 1.3.1?

@usmanrana07
Copy link

If I compare with PhotoView then Zoomage is missing less touches during swipe in a vertical ViewPager2 (means performing better in swipe). But still at some images with need to swipe twice/thrice. Another thing is that we don't have support to override LongPress method.

@usmanrana07
Copy link

Dragging the zoomed image with single finger is not smooth.

@jsibbold
Copy link
Owner

You're having to swipe multiple times with only some images?

@usmanrana07
Copy link

Yes, During swipe it may miss touch at any random images. Not necessarily on same images all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants