Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] It seems dangerous that requests api for contributor in this way #221

Open
currybob opened this issue Nov 2, 2018 · 0 comments

Comments

@currybob
Copy link
Collaborator

currybob commented Nov 2, 2018

Our contributor could change their name every moment.
But, Like PR #219 , if contributors change their name, API not works properly, because Promise.all returns just reject if any of Promise array rejects result.

2018-11-02 7 42 01

So now we would decide the way it reflects

2018-11-02 9 16 04

I tried this way to avoid "fast-fail-behavior" in Promise.all and it works
Please review it at #220 @gimdongwoo @thomasJang @aeei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant