ZoomToFit Typescript issue

[bruceborrett]

zoomToFit causes a typescript error saying that Geometry[] is not the correct type for the entities argument.

The return type of the function entitiesFromSolids is Geometry[] and zoomToFit is expecting this as input, so I assume this is a bug in the type declarations. If I change the zoomToFit function to expect Geometry[] then everything works as expected.

[platypii]

It looks like you found a bug, but your suggested fix is backwards. The return type of entitiesFromSolids should actually be an array of entities, not an array of geometries. So the bug is in entitiesFromSolids.d.ts, whereas zoomToFit looks correct.

If you look at how it's used in practice, the data type is a list of entities, which contain geometry as one of the properties:

Would you be willing to make a PR with a type definition fix?

[bruceborrett]

Has the entity type been defined anywhere yet?

[platypii]

I don't believe so. The closest is the inline type definition here for zoomToFit:

OpenJSCAD.org/packages/utils/regl-renderer/types/controls/orbitControls.d.ts

Line 100 in 4c1f372

export function zoomToFit({ controls, camera, entities }: {

But I think it would be nicer if we defined the Entity type explicitly.

[bruceborrett]

bruceborrett@5e6a792

Is something like this ok? Im not great with typescript and dont really understand the way that you have structured the types, perhaps you can guide me if Im way off.

[platypii]

Yes that's looking very nice, pretty much the same way I would have done it. Notes:

• the import in OrbitControls.d.ts needs to go to ../geometry-utils-V2/entity since its in an adjacent directory.
• very minor style nit: I would add some line breaks in your entity.d.ts so that Entity is not all one long line.

Thanks for looking into this!

[bruceborrett]

#1283