Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a formatter for Period/Duration #718

Open
lindboe opened this issue Mar 19, 2024 · 1 comment
Open

Adding a formatter for Period/Duration #718

lindboe opened this issue Mar 19, 2024 · 1 comment

Comments

@lindboe
Copy link

lindboe commented Mar 19, 2024

Thanks for this awesome library!

Would you be open to a contribution of a formatter for Period and Duration? I'm coming from joda-time which has PeriodFormatter, for example. I'm happy to see if I can contribute this if I get a little guidance on how you'd like this to be approached. (I see the README mentions a desire to refactor the existing formatter).

@pithu
Copy link
Member

pithu commented Mar 19, 2024

Hello @lindboe,

thank you, for using js-joda and you are very welcome to contribute. We decided to follow quite strictly the threeten API, it is somehow the predecessor project from joda-time. If you find something in the threeten API that is missing in js-joda we are open for PR's.

Here you find the homepage of threeten https://www.threeten.org/threetenbp/. I guess formatter for period/ duration are located in the extra module https://www.threeten.org/threeten-extra/ and should be ported to our extra package https://github.com/js-joda/js-joda/tree/main/packages/extra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants