Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't publish edited file #64

Open
vlotorev opened this issue Dec 31, 2017 · 4 comments
Open

Can't publish edited file #64

vlotorev opened this issue Dec 31, 2017 · 4 comments
Assignees
Labels

Comments

@vlotorev
Copy link

I edit a file in app, click Edit options-> Actions-> Publish but red notification with 'Request error' text pops up.

Publushing edited commit message works without errors.

@jruesga jruesga self-assigned this Dec 31, 2017
@jruesga jruesga added the bug label Dec 31, 2017
@jruesga
Copy link
Owner

jruesga commented Jan 1, 2018

@vlotorev I cannot reproduce this bug. Publishing an edited file works fine on my tests. Are always reproducible? What gerrit version? What kind of edit do you made? An edit over a new file, an edit over a modified file, a new add or modify operation over a file not previously in the change. Is it possible that someone published a new patchset whilist editing? In this last case, that is normal. Are you able to take a logcat of the error, so I can see which one is the underlaying error?

Thx.

@vlotorev vlotorev closed this as completed Jan 2, 2018
@vlotorev vlotorev reopened this Jan 2, 2018
@vlotorev
Copy link
Author

vlotorev commented Jan 2, 2018

Are always reproducible?

No, see below.

What gerrit version?

2.14.2

What kind of edit do you made? An edit over a new file, an edit over a modified file, a new add or modify operation over a file not previously in the change.

I have a change with several PS on server.
Change adds file.

In case I modify a couple of characters in the file then new PS is published ok.
In case I modify file replacing all the text with text copy-pasted from buffer then publishing ends with request error and sometimes it's not.
I can't provide precise steps to reproduce the issue.

Is it possible that someone published a new patchset whilist editing? In this last case, that is normal.

No.

Are you able to take a logcat of the error, so I can see which one is the underlaying error?

Probably in a cuople of weeks I be able to provide logs.

@jruesga
Copy link
Owner

jruesga commented Jan 3, 2018

By logcat, i was referring to your device logs, not the server logs (https://www.xda-developers.com/guide-sending-a-logcat-to-help-debug-your-favorite-app/). You must take the logcat after you get to reproduce the error again.

@vlotorev
Copy link
Author

vlotorev commented Jan 7, 2018

@jruesga, I won't be able to gather logs in the nearest future.
Also due to #65 I wouldn't like editing, as I won't be able to copy and save typed text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants