Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support supports_insert_on_conflict? #1090

Open
Louis-7 opened this issue Jun 21, 2021 · 0 comments
Open

Doesn't support supports_insert_on_conflict? #1090

Louis-7 opened this issue Jun 21, 2021 · 0 comments

Comments

@Louis-7
Copy link

Louis-7 commented Jun 21, 2021

I'm using this lib with activerecord-import. But it seems like the MySQL adapter in this gem is not implement supports_on_duplicate_key_update? related methods. activerecod-import can't add ON DUPLICATE KEY UPDATE to the sql statement because of mysql adapter tells it the DB is not supported ON DUPLICATE KEY UPDATE. But I'm sure MySQL supports it, read this ->How to INSERT If Row Does Not Exist (UPSERT) in MySQL.

Actually, activerecord-import already implement it, I copy/paste it into arjdbc/mysql/adapter.rb and it's working. I'm wondering if I can create a PR to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant