Trailer features

[Kishore1406]

Hi 

We faced an issue in adding the trailer to the X25 channel, so we worked on JPOS 2.1.8 and added the trailer to the X25 channel.

While working on it, we found that you deprecated the sendMessageTrailer in the Base channel. May we know in the future if there is any plan for adding trailer, or will we give a solution to add trailers to the Base channel?

[alcarraz]

You can use the correctly spelled version sendMessageTrailer

[Kishore1406]

We altered the sendMessageTrailer to pass the trailer in the x25 channel; it was working, and we added this solution in the basechannel. The trailer will work for all channels.

Existing Code:

Customized Code:

Please provide the guidelines for merge our code into JPOS source code.

[Kishore1406]

@alcarraz
We tried BASE24TCPChannel and BASE24Channel but it can add only 03(ETX) has trailer. We want 03d858 has trailer so we override the source code in BASEChannel to pass the dynamic trailer for all channels. Our business scenario X25 channel only receiving the response.

[alcarraz]

But why not extending one of them and add those bytes, taking Base24 or Base24TCP as a reference?

[Kishore1406]

But if we are extending any one of those channels BASE24TCPChannel and BASE24Channel it will be specific channel now we have add it in base channel so that it can be applicable to all the channel

[alcarraz]

Thing is, most of the channels, if not all, that don't override sendTrailer will just fail when a message with a trailer is sent over them with this modification.

[alcarraz]

Maybe, one option, could be to make it configurable in a boolean property, if the channel should honor the message trailer, but to make things consistent, you should also set the trailer on the message on receive.

This will take more work, and should be highly tested before merging it. It would touch many sensible places of the BaseChannel behavior, which is also at the core of the jPOS project.

[it240884sii]

it`s time to remove incorrectly spelled version and annotation @SuppressWarnings("deprecation") from correctly spelled. ready or not here i come =)

[ar]

We'll certainly do that in jPOS 3.0 ('next' branch).

[it240884sii]

life is to short for waiting next release...

[ar]

Not sure what's your point. The properly spelled methods are already available, and the old ones are flagged for deprecation.