-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG width and height do not consider units #837
Comments
Hi! how are you asking hugo to generate this? there’s a few ways to render an svg… theres a lot of nuance, as most of the tooling around images, especially in hugo have an expectation of a raster image… and don’t play well with vectors… so there’s some nuance and odd contortions one has to do at times to get things to play nice together if you can share the source you’re working with we might be able to offer some suggestions as to a solution that’ll work |
Here is code responsible for this congo/layouts/partials/picture.html Lines 14 to 24 in 50b77b2
options are:
UPD solution is to capture width and height together with units and output them in html as is. |
@stereobooster - I don't think it's as simple as that as the Using the reference image provided above and this modification: {{ range (findRESubmatch `<svg[^>]*width=["']([.0-9]*[a-zA-Z]*)["']` $svgContent 1) }}
{{ $width = index . 1 }}
{{ end }}
{{ range (findRESubmatch `<svg[^>]*height=["']([.0-9]*[a-zA-Z]*)["']` $svgContent 1) }}
{{ $height = index . 1 }}
{{ end }} Gives the following output: <img src="test.svg" width="3.07cm" height="3.07cm" class="mx-auto my-0 rounded-md" alt="Test" ...> But the actual image is still displayed as if it was 3.07px x 3.07px. |
@jpanther Indeed. I didn't realized that HTML width is not the same as CSS width. Hm... Maybe we can use CSS ( Other options:
|
Issue description
The width and height of this image are
3.07cm
:The following code will be generated:
Quoted from the SVG 1.1 specification:
Quoted from the
<img>
specification:According to these, the values of
width
andheight
in this case should be108.7795249
. However, the units are not actually considered, so a small image is rendered. Presumably, this will also occur in other units exceptpx
.Theme version
v2.8.1
Hugo version
hugo v0.124.0+extended linux/amd64
Which browser rendering engines are you seeing the problem on?
Firefox (Mozilla Firefox)
URL to sample repository or website
No response
Hugo output or build error messages
No response
The text was updated successfully, but these errors were encountered: