-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Badge shortcode injects linebreaks, precluding aligning several of them horizontally. #727
Comments
I'm not 100% sure this isn't a known issue/behavior... but I didn't see any mention of it in discussions or issues. |
I don't recall this being raised previously. I suppose it's probably just this way because that's how it's always been. I can't see any reason why it should be forced to appear on a new line, so this can be an enhancement. |
fair. I'd just thought I'd seen them arranged horizontally as with metadata tags, and figured that would be the default behavior. I came up with an.... interesting? way of addressing this... not sure if you like it or not, so I'll not file it as a PR:
usable like:
if you want me to file a PR, I will, but I'm sure there's likely a better way to accomplish the goal |
I worry that introducing all these params in a shortcode will make it unwieldy for most users. It is nice to be able to customise the output but this is extreme. Perhaps we could come up with a sensible subset of params that finds a middle ground? I feel like opacity, shading, borders, etc are all something that should be handled with a consistent design language so it could be more that there's a set of pre-defined styles and the values are calculated from that. Maybe the first step is to have It's also important to me to consider how these shortcode params would apply across the whole theme. It would be preferable to implement them in such a way that the same params could be reused for different elements. |
like I said I didn’t think it was a GOOD way of doing it, I just don’t like sayin “this doesn’t work” without demonstrating some investment in trying to resolve it. I agree it’s absurd as is…. but wanted to provide something to chew on to identify a preferred direction forward… i’d think 95% of the likely use cases would be met with a fairly small bundle of variants1…
prolly resulting in a few flavors of the colors:
thots? ¯\_(ツ)_/¯ Footnotes |
This issue has been automatically marked as stale because it has not had any recent activity. |
Issue description
Setup:
( Install gnu-sed and make the temp dest directory )
Verify current:
Prep:
Serve:
Demo abby normal
Inject a gaggle of badge-wrapped strings on a single line and let hugo regen page.
Theme version
2.7.6
Hugo version
0.120.4
Which browser rendering engines are you seeing the problem on?
Chromium (Google Chrome, Microsoft Edge, Brave, Vivaldi, Opera, etc.), WebKit (Safari)
URL to sample repository or website
No response
Hugo output or build error messages
The text was updated successfully, but these errors were encountered: