Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor headers to use same code #725

Closed

Conversation

Jh123x
Copy link
Contributor

@Jh123x Jh123x commented Nov 27, 2023

  • refactor: refactor contents to its own directories
  • refactor: share hybrid/basic/hamburger content
  • fix: fix mobile hybrid

Closes #721

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fc90695
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/658971454ede87000824d2e2
😎 Deploy Preview https://deploy-preview-725--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpanther jpanther added the enhancement New feature or request label Dec 23, 2023
Copy link

This pull request has been automatically marked as stale because it has not had any recent activity.
Please review the PR history and add a reply with any requested information. If no information has been requested, it may be that this contribution does not fit with the project objectives, or does not adhere to the contributing guidelines. If this is in error, please add a reply with further details.
This PR will automatically close in 30 days if no further activity occurs.

@github-actions github-actions bot added the stale This issue or pull request has not had any recent activity label Apr 24, 2024
@jpanther
Copy link
Owner

Sorry for leaving this PR around so long but one of the things I've been contemplating with this is whether this change is too simple.

For instance, I look at both the hamburger and basic content files and there's still a lot of repetition between the two. One of the goals I have in mind for this issue is to extract a whole bunch of the repetition like the appearance switcher and search into separate partials so that it's super easy to reuse them across a range of header templates.

This would also make it even easier for people to be able to override just one component of the header without having to make customisations to the entire block.

@github-actions github-actions bot removed the stale This issue or pull request has not had any recent activity label May 1, 2024
@Jh123x
Copy link
Contributor Author

Jh123x commented May 1, 2024

Sorry for leaving this PR around so long but one of the things I've been contemplating with this is whether this change is too simple.

For instance, I look at both the hamburger and basic content files and there's still a lot of repetition between the two. One of the goals I have in mind for this issue is to extract a whole bunch of the repetition like the appearance switcher and search into separate partials so that it's super easy to reuse them across a range of header templates.

This would also make it even easier for people to be able to override just one component of the header without having to make customisations to the entire block.

Will continue again based on the current dev branch once I have more time 👍

@Jh123x Jh123x closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code repetition in header layouts
2 participants