Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code repetition in header layouts #721

Open
jpanther opened this issue Nov 25, 2023 · 1 comment
Open

Remove code repetition in header layouts #721

jpanther opened this issue Nov 25, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Community submissions are encouraged

Comments

@jpanther
Copy link
Owner

A long standing todo list item for this project is to refactor the header layouts to reduce the code repetition between the various layouts. Currently the hybrid layout duplicates the code from basic and hamburger and leads to issues when they are not kept in parity.

There's also potential to extract parts of the logic into functions so they can be reused in a more generic way. This would then allow more header layouts to be created without the overhead of maintaining support for existing features in every layout.

I'm creating this as an issue in case there's anyone in the community who has the time to look at submitting a PR for this change.

@jpanther jpanther added enhancement New feature or request help wanted Community submissions are encouraged labels Nov 25, 2023
Copy link

This issue has been automatically marked as stale because it has not had any recent activity.
If you are still experiencing this issue, please review the issue history and add a reply with any requested and/or additional information in order to keep the issue open.
This issue will automatically close in 30 days if no further activity occurs.

@github-actions github-actions bot added the stale This issue or pull request has not had any recent activity label Mar 25, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@jpanther jpanther removed the stale This issue or pull request has not had any recent activity label Apr 29, 2024
@jpanther jpanther reopened this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Community submissions are encouraged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant