Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCS 4.0.34: Unhandled error when exporting missing linked table #500

Open
HughWarrington opened this issue Mar 22, 2024 · 3 comments
Open

VCS 4.0.34: Unhandled error when exporting missing linked table #500

HughWarrington opened this issue Mar 22, 2024 · 3 comments
Labels
pending resolved Possibly resolved, needs testing or confirmation

Comments

@HughWarrington
Copy link 

-------------------------------------
my_database.mdb
VCS Version 4.0.34
Performing Full Export
22/03/2024 13:30:09
-------------------------------------

Running with debug enabled.

image

image

I think the screenshots help explain what's going on.

It's trying to export data from a table. clsDbTableData.GetTableExportSql has generated a select query that is missing the ORDER BY columns at the end. I'm guessing this is because the table in question is a linked table that cannot be found on disk.

I'm not sure what the conventions are in this project (or in Access/VB in general) but perhaps we should instead log a meaningful warning saying 'missing linked table' or similar.
@joyfullservice
Copy link
Owner

Yes, it looks like we should test to ensure the table exists and is available before attempting an export of the data. Good idea!

joyfullservice added a commit that referenced this issue Mar 22, 2024
@joyfullservice
Ensure table object exists before export
16e6983 
A linked table may exist in the current database, but if the target is not accessible, it will generate an error when exporting the table definition or table data. This change logs the issue and warns the user of the problem. #500
@joyfullservice
Copy link
Owner

Added some code to ensure the availability of the target for linked tables, and logs the error more clearly for the user.

image

@joyfullservice joyfullservice added the pending resolved Possibly resolved, needs testing or confirmation label Mar 22, 2024
@HughWarrington
Copy link
Author

Brilliant! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending resolved Possibly resolved, needs testing or confirmation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HughWarrington @joyfullservice