You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@josef-poetzl - Thanks for pointing this out! I like the concepts you implemented in the suggested fix. But as I dug into it a little deeper, I think I found an underlying issue that may solve this in an even more elegant way.
As you pointed out the Log instance is destroyed by the call to ReleaseObjects. Stepping through the code, this actually happens twice, once as the export finishes, and a second time as the clsVersionControl class is terminated.
Ideally, I would like to persist the log object during the duration of the entire operation triggered by the ribbon button click. This will allow the form UI code to check the Log.ErrorLevel after the conclusion of the export, but before the form is closed. When the clsVersionControl class terminates at the conclusion of the entire operation, the objects are released. I believe that by removing the redundant (early) calls to ReleaseObjects, we can resolve this issue.
I still made this adjustment: josef-poetzl@ea1a37e
=> to allow add enum items between Warning and Error
Note: This is a test branch where I test the interface for AccUnit - with minimal customization of the msaccess-vcs-addin.
(see: #493)
When Export Source is started from the ribbon, the main form does not remain open despite an error message.
AutoClose is always triggered.
Cause: Log.ErrorLevel is always 0, as the log instance in the export methods is destroyed.
see: josef-poetzl@6cdb15b
Fix:
josef-poetzl@36948e5
The text was updated successfully, but these errors were encountered: