Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship paths in include not supported #208

Open
PhyberApex opened this issue Oct 16, 2018 · 3 comments
Open

Relationship paths in include not supported #208

PhyberApex opened this issue Oct 16, 2018 · 3 comments

Comments

@PhyberApex
Copy link
Contributor

As stated https://jsonapi.org/format/#fetching-includes in the JSON API specification. A nested releationship should be included and the dot should be used as a path seperator for such includes.

Currently Saule does not implement this and does not respond with the needed 400 Bad Request message if such an path is encountered.

Same as the other issues I opened. If I find the spare time I would like to open a PR for that.

~Cheers

@PhyberApex
Copy link
Contributor Author

I just took a closer look at this and it seems that nested relationships are not handled at all. I will probably need some assistance to get this to work with the serializer but I will take a close look at this somewhat soonish.

~Cheers

@PhyberApex
Copy link
Contributor Author

Geez with the current implementation this does not seem possible at all. A relationship of a relationship is just not known to Saule...seems like this is impossible to fix...

~Cheers

@joukevandermaas
Copy link
Owner

I think this should be possible even if the current implementation does not support it. I have to admit I don't remember all the details of the serializer exactly, but it seems like something that should be supported. I will try to look into it sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants