Tweak set up instructions #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
yiendos
reviewed
Jul 15, 2023
README.md
Outdated
|
|
||
| If you wanted to run all of these services at once: | ||
|
|
||
| `docker compose --profile all up -d ` |
There was a problem hiding this comment.
hmm docker compose commands, when we have:
https://github.com/joomlatools/joomlatools-server/blob/master/bin/jtctl
Establish how to provide profile arguments into this command and remove references to docker compose
There was a problem hiding this comment.
sh bin/jtctl start
Actually loads up all available profiles:
https://github.com/joomlatools/joomlatools-server/blob/master/bin/jtctl#L183
So this issue/ Pull request is not needed
|
@johanjanssens turned out to be pretty simple in the end, the jtctl start command takes care of launching the composer profiles automatically, my bad. I did notice that in the README we make no mention of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103