-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to CKEditor 5 #44
Comments
@jebbdomingo If this requires a complete upgrade of CKEditor then that would be too much work. It's not need, people will not be uploading webp images, they are mostly converted on the fly from other image types. |
CKEditor 5 no longer have global repository of editors.
@johanjanssens As with https://github.com/joomlatools/textman/issues/436, it works on TEXTman but there's still some bug in Joomla editor xtd buttons that needs further investigation. The major change that needs to be done in extensions that will use this is the new way to initialize/create an editor which now uses a promise. I created a small function to facilitate access to the created editors as v5 no longer uses a global repository of editors. I suggest we just leave this change for now for future reference. |
@jebbdomingo Oki, so you are suggestion to leave this as is and not upgrade it yet? Keep the PR open for future work? |
@johanjanssens Yes, sir. |
Agreed. |
Upgrade to the latest version of CKEditor to support webp image.
https://github.com/joomlatools/textman/issues/436
The text was updated successfully, but these errors were encountered: