Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CKEditor 5 #44

Open
jebbdomingo opened this issue Oct 21, 2020 · 5 comments · May be fixed by #45
Open

Upgrade to CKEditor 5 #44

jebbdomingo opened this issue Oct 21, 2020 · 5 comments · May be fixed by #45
Assignees
Labels
Milestone

Comments

@jebbdomingo
Copy link
Member

Upgrade to the latest version of CKEditor to support webp image.
https://github.com/joomlatools/textman/issues/436

@jebbdomingo jebbdomingo added this to the 1.2 milestone Oct 21, 2020
@jebbdomingo jebbdomingo self-assigned this Oct 21, 2020
@johanjanssens
Copy link
Member

@jebbdomingo If this requires a complete upgrade of CKEditor then that would be too much work. It's not need, people will not be uploading webp images, they are mostly converted on the fly from other image types.

@jebbdomingo jebbdomingo reopened this Oct 22, 2020
jebbdomingo added a commit that referenced this issue Oct 23, 2020
CKEditor 5 no longer have global repository of editors.
@github-actions github-actions bot linked a pull request Oct 23, 2020 that will close this issue
@jebbdomingo
Copy link
Member Author

@johanjanssens As with https://github.com/joomlatools/textman/issues/436, it works on TEXTman but there's still some bug in Joomla editor xtd buttons that needs further investigation. The major change that needs to be done in extensions that will use this is the new way to initialize/create an editor which now uses a promise. I created a small function to facilitate access to the created editors as v5 no longer uses a global repository of editors. I suggest we just leave this change for now for future reference.

@johanjanssens
Copy link
Member

@jebbdomingo Oki, so you are suggestion to leave this as is and not upgrade it yet? Keep the PR open for future work?

@jebbdomingo
Copy link
Member Author

@jebbdomingo Oki, so you are suggestion to leave this as is and not upgrade it yet? Keep the PR open for future work?

@johanjanssens Yes, sir.

@johanjanssens
Copy link
Member

Agreed.

@jebbdomingo jebbdomingo modified the milestones: 1.2, Backlog Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants